Feature | Add "Command Timeout" connection string property#722
Merged
Conversation
Member
Hi @ErikEJ Yes, that's correct. Basically the XML files contain 1:1 documentation of all public APIs in the driver in order to use them in both NetFx and NetCore source to reduce duplication. |
Contributor
Author
|
@cheenamalhotra This is ready for review now 😄 |
johnnypham
reviewed
Sep 16, 2020
johnnypham
reviewed
Sep 16, 2020
johnnypham
approved these changes
Sep 16, 2020
cheenamalhotra
approved these changes
Sep 17, 2020
Contributor
Author
|
Thanks for getting this in, a very useful new feature imho. |
TrayanZapryanov
pushed a commit
to TrayanZapryanov/SqlClient
that referenced
this pull request
Sep 18, 2020
This was referenced Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allow the default CommandTimeout of 30 seconds to be overridden, without any code changes.
fixes #614
QUESTION re missing docs:
I am not familiar with the way XML docs are created here, should I add something similar to this:
https://github.com/dotnet/SqlClient/blob/master/doc/snippets/Microsoft.Data.SqlClient/SqlCommand.xml#L1217
in the SqlConnection.xml and SqlConnectionString.xml files?